feat(composer): v3.4 — inline direct-manipulation on hero (closes #24)#28
Merged
Conversation
Hero card blocks in the Compose canvas now render as inline SVG so the data-cas-target hooks emitted by hero.js (#27) can attach click handlers. Two interactions land: - bg click → popover with the 4 background options (gradient / wave / grid / particles). Selection updates the slot, persists, re-renders. Outside click dismisses; viewport clamping keeps the popover on screen near edges. - name / subtitle click → the corresponding input in the right-pane slot inspector receives focus + select-all + a brief accent flash. Click-to-jump beats trying to make SVG <text> contenteditable reliably across browsers; real text-in-canvas edit is v3.4.x. Out of MVP (deferred): inline edit on stats / pin / languages / snake, color picker for theme, keyboard a11y, drag-handle reorder. Other card types still render as <img>.
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hero blocks now render inline SVG. Click on bg → popover picker. Click on name/subtitle → focuses the slot input with a brief flash. Other card types remain as![]()
for now. See #24.